Commit 26300860 authored Mar 31, 2023 by Thomas Richter Committed by Vasily Gorbik Apr 13, 2023

s390/cpum_cf: remove unnecessary copy_from_user call



Struct s390_ctrset_read userdata is filled by ioctl_read operation
using put_user/copy_to_user. However, the ctrset->data value access
is not performed anywhere during the ioctl_read operation.
Remove unnecessary copy_from_user() call.
No functional change.

Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
Suggested-by: Sumanth Korikkar <sumanthk@linux.ibm.com>
Acked-by: Sumanth Korikkar <sumanthk@linux.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>

parent 3cdf0269

arch/s390/kernel/perf_cpum_cf.c

+1 −5

Original line number	Diff line number	Diff line
		@@ -1388,14 +1388,10 @@ static int cfset_all_read(unsigned long arg, struct cfset_request *req)

		static long cfset_ioctl_read(unsigned long arg, struct cfset_request *req)
		{
		struct s390_ctrset_read read;
		int ret = -ENODATA;

		if (req && req->ctrset) {
		if (copy_from_user(&read, (char __user *)arg, sizeof(read)))
		return -EFAULT;
		if (req && req->ctrset)
		ret = cfset_all_read(arg, req);
		}
		return ret;
		}