Commit 264e8de2 authored Mar 24, 2022 by Jakob Koschel Committed by Hans de Goede Apr 13, 2022

platform/x86: wmi: replace usage of found with dedicated list iterator variable

To move the list iterator variable into the list_for_each_entry_*()
macro in the future it should be avoided to use the list iterator
variable after the loop body.

To *never* use the list iterator variable after the loop it was
concluded to use a separate iterator variable instead of a
found boolean [1].

This removes the need to use a found variable and simply checking if
the variable was set, can determine if the break/goto was hit.

Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/


Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Link: https://lore.kernel.org/r/20220324072015.62063-1-jakobkoschel@gmail.com


Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>

parent 34354476

drivers/platform/x86/wmi.c

+6 −7

Original line number	Diff line number	Diff line
		@@ -1308,21 +1308,20 @@ acpi_wmi_ec_space_handler(u32 function, acpi_physical_address address,
		static void acpi_wmi_notify_handler(acpi_handle handle, u32 event,
		void *context)
		{
		struct wmi_block *wblock;
		bool found_it = false;
		struct wmi_block wblock = NULL, iter;

		list_for_each_entry(wblock, &wmi_block_list, list) {
		struct guid_block *block = &wblock->gblock;
		list_for_each_entry(iter, &wmi_block_list, list) {
		struct guid_block *block = &iter->gblock;

		if (wblock->acpi_device->handle == handle &&
		if (iter->acpi_device->handle == handle &&
		(block->flags & ACPI_WMI_EVENT) &&
		(block->notify_id == event)) {
		found_it = true;
		wblock = iter;
		break;
		}
		}

		if (!found_it)
		if (!wblock)
		return;

		/* If a driver is bound, then notify the driver. */