Commit 26d4a969 authored by Xiang Chen's avatar Xiang Chen Committed by Martin K. Petersen
Browse files

scsi: libsas: Use void for sas_discover_event() return code 

The callers of function sas_discover_event() do not check its return value.
The function also only ever returns 0, so use void instead.

Link: https://lore.kernel.org/r/1644561778-183074-2-git-send-email-chenxiang66@hisilicon.com


Reviewed-by: default avatarJohn Garry <john.garry@huawei.com>
Signed-off-by: default avatarXiang Chen <chenxiang66@hisilicon.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent f69b0791

drivers/scsi/libsas/sas_discover.c

+2 −4
Original line number Diff line number Diff line
@@ -545,19 +545,17 @@ static void sas_chain_event(int event, unsigned long *pending, 
	}

}



int sas_discover_event(struct asd_sas_port *port, enum discover_event ev)

void sas_discover_event(struct asd_sas_port *port, enum discover_event ev)

{

	struct sas_discovery *disc;



	if (!port)

		return 0;

		return;

	disc = &port->disc;



	BUG_ON(ev >= DISC_NUM_EVENTS);



	sas_chain_event(ev, &disc->pending, &disc->disc_work[ev].work, port->ha);



	return 0;

}



/**

include/scsi/libsas.h

+1 −1
Original line number Diff line number Diff line
@@ -684,7 +684,7 @@ int sas_ex_revalidate_domain(struct domain_device *); 


void sas_unregister_domain_devices(struct asd_sas_port *port, int gone);

void sas_init_disc(struct sas_discovery *disc, struct asd_sas_port *);

int  sas_discover_event(struct asd_sas_port *, enum discover_event ev);

void sas_discover_event(struct asd_sas_port *, enum discover_event ev);



int  sas_discover_sata(struct domain_device *);

int  sas_discover_end_dev(struct domain_device *);