Commit 26f44837 authored by Martin Kaiser's avatar Martin Kaiser Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: fix memleak in rtw_wx_set_enc_ext 



Free the param struct if the caller sets an unsupported algorithm
and we return an error.

Fixes: 2b42bd58 ("staging: r8188eu: introduce new os_dep dir for RTL8188eu driver")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarMartin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20211019202356.12572-1-martin@kaiser.cx


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c052cc1a

drivers/staging/r8188eu/os_dep/ioctl_linux.c

+3 −2
Original line number Diff line number Diff line
@@ -1897,7 +1897,7 @@ static int rtw_wx_set_enc_ext(struct net_device *dev, 
	struct ieee_param *param = NULL;

	struct iw_point *pencoding = &wrqu->encoding;

	struct iw_encode_ext *pext = (struct iw_encode_ext *)extra;

	int ret = 0;

	int ret = -1;



	param_len = sizeof(struct ieee_param) + pext->key_len;

	param = kzalloc(param_len, GFP_KERNEL);
@@ -1923,7 +1923,7 @@ static int rtw_wx_set_enc_ext(struct net_device *dev, 
		alg_name = "CCMP";

		break;

	default:

		return -1;

		goto out;

	}



	strlcpy((char *)param->u.crypt.alg, alg_name, IEEE_CRYPT_ALG_NAME_LEN);
@@ -1950,6 +1950,7 @@ static int rtw_wx_set_enc_ext(struct net_device *dev, 


	ret =  wpa_set_encryption(dev, param, param_len);



out:

	kfree(param);

	return ret;

}