Commit 272a1219 authored by Denis Efremov's avatar Denis Efremov Committed by David Howells
Browse files

security/keys: use kvfree_sensitive() 



Use kvfree_sensitive() instead of open-coding it.

Signed-off-by: default avatarDenis Efremov <efremov@linux.com>
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Reviewed-by: default avatarJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Reviewed-by: default avatarBen Boeckel <mathstuf@gmail.com>
parent 8fe62e0c

security/keys/big_key.c

+3 −6
Original line number Diff line number Diff line
@@ -121,8 +121,7 @@ int big_key_preparse(struct key_preparsed_payload *prep) 
		*path = file->f_path;

		path_get(path);

		fput(file);

		memzero_explicit(buf, enclen);

		kvfree(buf);

		kvfree_sensitive(buf, enclen);

	} else {

		/* Just store the data in a buffer */

		void *data = kmalloc(datalen, GFP_KERNEL);
@@ -140,8 +139,7 @@ int big_key_preparse(struct key_preparsed_payload *prep) 
err_enckey:

	kfree_sensitive(enckey);

error:

	memzero_explicit(buf, enclen);

	kvfree(buf);

	kvfree_sensitive(buf, enclen);

	return ret;

}
@@ -273,8 +271,7 @@ long big_key_read(const struct key *key, char *buffer, size_t buflen) 
err_fput:

		fput(file);

error:

		memzero_explicit(buf, enclen);

		kvfree(buf);

		kvfree_sensitive(buf, enclen);

	} else {

		ret = datalen;

		memcpy(buffer, key->payload.data[big_key_data], datalen);