Commit 28210a3f authored by Philip Chen's avatar Philip Chen Committed by Douglas Anderson
Browse files

drm/bridge: parade-ps8640: Reorg the macros 



Reorg the macros as follows:
(1) Group the registers on the same page together.
(2) Group the register and its bit operation together while indenting
the macros of the bit operation with one space.

Also fix a misnomer for the number of mipi data lanes.

Signed-off-by: default avatarPhilip Chen <philipchen@chromium.org>
Acked-by: default avatarSam Ravnborg <sam@ravnborg.org>
Reviewed-by: default avatarStephen Boyd <swboyd@chromium.org>
Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210824181140.v2.1.I8ead7431357409f2526e5739ec5bc3ddfd242243@changeid
parent 60aede70

drivers/gpu/drm/bridge/parade-ps8640.c

+10 −8
Original line number Diff line number Diff line
@@ -23,11 +23,13 @@ 
#define  I2C_BYPASS_EN		0xd0

#define PAGE2_MCS_EN		0xf3

#define  MCS_EN			BIT(0)



#define PAGE3_SET_ADD		0xfe

#define  VDO_CTL_ADD		0x13

#define  VDO_DIS		0x18

#define  VDO_EN			0x1c

#define DP_NUM_LANES		4



#define NUM_MIPI_LANES		4



/*

 * PS8640 uses multiple addresses:
@@ -254,7 +256,7 @@ static int ps8640_bridge_attach(struct drm_bridge *bridge, 
	dsi->mode_flags = MIPI_DSI_MODE_VIDEO |

			  MIPI_DSI_MODE_VIDEO_SYNC_PULSE;

	dsi->format = MIPI_DSI_FMT_RGB888;

	dsi->lanes = DP_NUM_LANES;

	dsi->lanes = NUM_MIPI_LANES;

	ret = mipi_dsi_attach(dsi);

	if (ret)

		goto err_dsi_attach;