Commit 28502e02 authored by Jérôme Pouiller's avatar Jérôme Pouiller Committed by Greg Kroah-Hartman
Browse files

staging: wfx: drop useless update of field basic_rate_set 



Basic Rates are already set by hif_join(). hif_join() is also able to
manage possible changes after association.

Firmware also allows to change the Basic Rates with
hif_set_association_mode() but it does not bring anything in our case.

Signed-off-by: default avatarJérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20200420160311.57323-10-Jerome.Pouiller@silabs.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7b0360e5

drivers/staging/wfx/hif_tx_mib.c

+0 −3
Original line number Diff line number Diff line
@@ -190,15 +190,12 @@ int hif_set_block_ack_policy(struct wfx_vif *wvif, 
int hif_set_association_mode(struct wfx_vif *wvif,

			     struct ieee80211_bss_conf *info)

{

	int basic_rates = wfx_rate_mask_to_hw(wvif->wdev, info->basic_rates);

	struct ieee80211_sta *sta = NULL;

	struct hif_mib_set_association_mode val = {

		.preambtype_use = 1,

		.mode = 1,

		.rateset = 1,

		.spacing = 1,

		.short_preamble = info->use_short_preamble,

		.basic_rate_set = cpu_to_le32(basic_rates)

	};



	rcu_read_lock(); // protect sta