Unverified Commit 292b544e authored by Vijendar Mukunda's avatar Vijendar Mukunda Committed by Mark Brown
Browse files

ASoC: SOF: amd: refactor get_chip_info callback 



Move get_chip_info callback to the start of API.
This should be first check in probe() call.

Signed-off-by: default avatarVijendar Mukunda <Vijendar.Mukunda@amd.com>
Link: https://lore.kernel.org/r/20230403071651.919027-4-Vijendar.Mukunda@amd.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 2675de62

sound/soc/sof/amd/acp.c

+5 −7
Original line number Diff line number Diff line
@@ -470,6 +470,11 @@ int amd_sof_acp_probe(struct snd_sof_dev *sdev) 
	unsigned int addr;

	int ret;



	chip = get_chip_info(sdev->pdata);

	if (!chip) {

		dev_err(sdev->dev, "no such device supported, chip id:%x\n", pci->device);

		return -EIO;

	}

	adata = devm_kzalloc(sdev->dev, sizeof(struct acp_dev_data),

			     GFP_KERNEL);

	if (!adata)
@@ -486,13 +491,6 @@ int amd_sof_acp_probe(struct snd_sof_dev *sdev) 
	pci_set_master(pci);



	sdev->pdata->hw_pdata = adata;



	chip = get_chip_info(sdev->pdata);

	if (!chip) {

		dev_err(sdev->dev, "no such device supported, chip id:%x\n", pci->device);

		return -EIO;

	}



	adata->smn_dev = pci_get_device(PCI_VENDOR_ID_AMD, chip->host_bridge_id, NULL);

	if (!adata->smn_dev) {

		dev_err(sdev->dev, "Failed to get host bridge device\n");