Commit 2a954832 authored by Harshit Mogalapalli's avatar Harshit Mogalapalli Committed by Martin K. Petersen
Browse files

scsi: mpi3mr: Use -ENOMEM instead of -1 in mpi3mr_expander_add() 



smatch warnings:

drivers/scsi/mpi3mr/mpi3mr_transport.c:1449 mpi3mr_expander_add() warn:
	returning -1 instead of -ENOMEM is sloppy

No functional change.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <error27@gmail.com>
Link: https://lore.kernel.org/r/202303202027.ZeDQE5Ug-lkp@intel.com/


Signed-off-by: default avatarHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Link: https://lore.kernel.org/r/20230419064256.2532069-1-harshit.m.mogalapalli@oracle.com


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent ac9a7868

drivers/scsi/mpi3mr/mpi3mr_transport.c

+1 −1
Original line number Diff line number Diff line
@@ -2058,7 +2058,7 @@ int mpi3mr_expander_add(struct mpi3mr_ioc *mrioc, u16 handle) 
	sas_expander = kzalloc(sizeof(struct mpi3mr_sas_node),

	    GFP_KERNEL);

	if (!sas_expander)

		return -1;

		return -ENOMEM;



	sas_expander->handle = handle;

	sas_expander->num_phys = expander_pg0.num_phys;