Commit 2b7d07f7 authored by Yuan Can's avatar Yuan Can Committed by Jarkko Sakkinen
Browse files

tpm/tpm_ftpm_tee: Fix error handling in ftpm_mod_init() 



The ftpm_mod_init() returns the driver_register() directly without checking
its return value, if driver_register() failed, the ftpm_tee_plat_driver is
not unregistered.

Fix by unregister ftpm_tee_plat_driver when driver_register() failed.

Fixes: 9f1944c2 ("tpm_ftpm_tee: register driver on TEE bus")
Signed-off-by: default avatarYuan Can <yuancan@huawei.com>
Reviewed-by: default avatarMaxim Uvarov <maxim.uvarov@linaro.org>
Acked-by: default avatarJarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: default avatarJarkko Sakkinen <jarkko@kernel.org>
parent db9622f7

drivers/char/tpm/tpm_ftpm_tee.c

+7 −1
Original line number Diff line number Diff line
@@ -397,7 +397,13 @@ static int __init ftpm_mod_init(void) 
	if (rc)

		return rc;



	return driver_register(&ftpm_tee_driver.driver);

	rc = driver_register(&ftpm_tee_driver.driver);

	if (rc) {

		platform_driver_unregister(&ftpm_tee_plat_driver);

		return rc;

	}



	return 0;

}



static void __exit ftpm_mod_exit(void)