Commit 2cb5cadf authored by Oliver Neukum's avatar Oliver Neukum Committed by Mauro Carvalho Chehab
Browse files

media: xbox_remote: xbox_remote_initialize() cannot fail



It cannot fail. Make it void.

Signed-off-by: default avatarOliver Neukum <oneukum@suse.com>
Signed-off-by: default avatarSean Young <sean@mess.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 6f2f124a
Loading
Loading
Loading
Loading
+3 −7
Original line number Diff line number Diff line
@@ -163,7 +163,7 @@ static void xbox_remote_rc_init(struct xbox_remote *xbox_remote)
	rdev->dev.parent = &xbox_remote->interface->dev;
}

static int xbox_remote_initialize(struct xbox_remote *xbox_remote,
static void xbox_remote_initialize(struct xbox_remote *xbox_remote,
				   struct usb_endpoint_descriptor *endpoint_in)
{
	struct usb_device *udev = xbox_remote->udev;
@@ -177,8 +177,6 @@ static int xbox_remote_initialize(struct xbox_remote *xbox_remote,
	usb_fill_int_urb(xbox_remote->irq_urb, udev, pipe, xbox_remote->inbuf,
			 maxp, xbox_remote_irq_in, xbox_remote,
			 endpoint_in->bInterval);

	return 0;
}

/*
@@ -249,9 +247,7 @@ static int xbox_remote_probe(struct usb_interface *interface,
	xbox_remote_rc_init(xbox_remote);

	/* Device Hardware Initialization */
	err = xbox_remote_initialize(xbox_remote, endpoint_in);
	if (err)
		goto exit_kill_urbs;
	xbox_remote_initialize(xbox_remote, endpoint_in);

	/* Set up and register rc device */
	err = rc_register_device(xbox_remote->rdev);