Commit 2d343087 authored by Al Viro's avatar Al Viro
Browse files

overlayfs: constify path 



Reviewed-by: default avatarChristian Brauner (Microsoft) <brauner@kernel.org>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent d5bf8889

fs/overlayfs/copy_up.c

+6 −6
Original line number Diff line number Diff line
@@ -44,7 +44,7 @@ static bool ovl_must_copy_xattr(const char *name) 
	       !strncmp(name, XATTR_SECURITY_PREFIX, XATTR_SECURITY_PREFIX_LEN);

}



int ovl_copy_xattr(struct super_block *sb, struct path *oldpath, struct dentry *new)

int ovl_copy_xattr(struct super_block *sb, const struct path *oldpath, struct dentry *new)

{

	struct dentry *old = oldpath->dentry;

	ssize_t list_size, size, value_size = 0;
@@ -132,8 +132,8 @@ int ovl_copy_xattr(struct super_block *sb, struct path *oldpath, struct dentry * 
	return error;

}



static int ovl_copy_fileattr(struct inode *inode, struct path *old,

			     struct path *new)

static int ovl_copy_fileattr(struct inode *inode, const struct path *old,

			     const struct path *new)

{

	struct fileattr oldfa = { .flags_valid = true };

	struct fileattr newfa = { .flags_valid = true };
@@ -193,8 +193,8 @@ static int ovl_copy_fileattr(struct inode *inode, struct path *old, 
	return ovl_real_fileattr_set(new, &newfa);

}



static int ovl_copy_up_data(struct ovl_fs *ofs, struct path *old,

			    struct path *new, loff_t len)

static int ovl_copy_up_data(struct ovl_fs *ofs, const struct path *old,

			    const struct path *new, loff_t len)

{

	struct file *old_file;

	struct file *new_file;
@@ -872,7 +872,7 @@ static bool ovl_need_meta_copy_up(struct dentry *dentry, umode_t mode, 
	return true;

}



static ssize_t ovl_getxattr_value(struct path *path, char *name, char **value)

static ssize_t ovl_getxattr_value(const struct path *path, char *name, char **value)

{

	ssize_t res;

	char *buf;

fs/overlayfs/file.c

+1 −1
Original line number Diff line number Diff line
@@ -38,7 +38,7 @@ static char ovl_whatisit(struct inode *inode, struct inode *realinode) 
#define OVL_OPEN_FLAGS (O_NOATIME | FMODE_NONOTIFY)



static struct file *ovl_open_realfile(const struct file *file,

				      struct path *realpath)

				      const struct path *realpath)

{

	struct inode *realinode = d_inode(realpath->dentry);

	struct inode *inode = file_inode(file);

fs/overlayfs/inode.c

+3 −3
Original line number Diff line number Diff line
@@ -585,7 +585,7 @@ static int ovl_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, 
 * Introducing security_inode_fileattr_get/set() hooks would solve this issue

 * properly.

 */

static int ovl_security_fileattr(struct path *realpath, struct fileattr *fa,

static int ovl_security_fileattr(const struct path *realpath, struct fileattr *fa,

				 bool set)

{

	struct file *file;
@@ -607,7 +607,7 @@ static int ovl_security_fileattr(struct path *realpath, struct fileattr *fa, 
	return err;

}



int ovl_real_fileattr_set(struct path *realpath, struct fileattr *fa)

int ovl_real_fileattr_set(const struct path *realpath, struct fileattr *fa)

{

	int err;
@@ -682,7 +682,7 @@ static void ovl_fileattr_prot_flags(struct inode *inode, struct fileattr *fa) 
	}

}



int ovl_real_fileattr_get(struct path *realpath, struct fileattr *fa)

int ovl_real_fileattr_get(const struct path *realpath, struct fileattr *fa)

{

	int err;

fs/overlayfs/namei.c

+2 −2
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ struct ovl_lookup_data { 
	bool metacopy;

};



static int ovl_check_redirect(struct path *path, struct ovl_lookup_data *d,

static int ovl_check_redirect(const struct path *path, struct ovl_lookup_data *d,

			      size_t prelen, const char *post)

{

	int res;
@@ -194,7 +194,7 @@ struct dentry *ovl_decode_real_fh(struct ovl_fs *ofs, struct ovl_fh *fh, 
	return real;

}



static bool ovl_is_opaquedir(struct ovl_fs *ofs, struct path *path)

static bool ovl_is_opaquedir(struct ovl_fs *ofs, const struct path *path)

{

	return ovl_path_check_dir_xattr(ofs, path, OVL_XATTR_OPAQUE);

}

fs/overlayfs/overlayfs.h

+11 −11
Original line number Diff line number Diff line
@@ -208,7 +208,7 @@ static inline int ovl_do_symlink(struct ovl_fs *ofs, 
	return err;

}



static inline ssize_t ovl_do_getxattr(struct path *path, const char *name,

static inline ssize_t ovl_do_getxattr(const struct path *path, const char *name,

				      void *value, size_t size)

{

	int err, len;
@@ -238,7 +238,7 @@ static inline ssize_t ovl_getxattr_upper(struct ovl_fs *ofs, 
}



static inline ssize_t ovl_path_getxattr(struct ovl_fs *ofs,

					 struct path *path,

					 const struct path *path,

					 enum ovl_xattr ox, void *value,

					 size_t size)

{
@@ -401,13 +401,13 @@ void ovl_inode_update(struct inode *inode, struct dentry *upperdentry); 
void ovl_dir_modified(struct dentry *dentry, bool impurity);

u64 ovl_dentry_version_get(struct dentry *dentry);

bool ovl_is_whiteout(struct dentry *dentry);

struct file *ovl_path_open(struct path *path, int flags);

struct file *ovl_path_open(const struct path *path, int flags);

int ovl_copy_up_start(struct dentry *dentry, int flags);

void ovl_copy_up_end(struct dentry *dentry);

bool ovl_already_copied_up(struct dentry *dentry, int flags);

bool ovl_path_check_dir_xattr(struct ovl_fs *ofs, struct path *path,

bool ovl_path_check_dir_xattr(struct ovl_fs *ofs, const struct path *path,

			      enum ovl_xattr ox);

bool ovl_path_check_origin_xattr(struct ovl_fs *ofs, struct path *path);

bool ovl_path_check_origin_xattr(struct ovl_fs *ofs, const struct path *path);



static inline bool ovl_check_origin_xattr(struct ovl_fs *ofs,

					  struct dentry *upperdentry)
@@ -430,9 +430,9 @@ bool ovl_need_index(struct dentry *dentry); 
int ovl_nlink_start(struct dentry *dentry);

void ovl_nlink_end(struct dentry *dentry);

int ovl_lock_rename_workdir(struct dentry *workdir, struct dentry *upperdir);

int ovl_check_metacopy_xattr(struct ovl_fs *ofs, struct path *path);

int ovl_check_metacopy_xattr(struct ovl_fs *ofs, const struct path *path);

bool ovl_is_metacopy_dentry(struct dentry *dentry);

char *ovl_get_redirect_xattr(struct ovl_fs *ofs, struct path *path, int padding);

char *ovl_get_redirect_xattr(struct ovl_fs *ofs, const struct path *path, int padding);

int ovl_sync_status(struct ovl_fs *ofs);



static inline void ovl_set_flag(unsigned long flag, struct inode *inode)
@@ -556,7 +556,7 @@ void ovl_cleanup_whiteouts(struct ovl_fs *ofs, struct dentry *upper, 
			   struct list_head *list);

void ovl_cache_free(struct list_head *list);

void ovl_dir_cache_free(struct inode *inode);

int ovl_check_d_type_supported(struct path *realpath);

int ovl_check_d_type_supported(const struct path *realpath);

int ovl_workdir_cleanup(struct ovl_fs *ofs, struct inode *dir,

			struct vfsmount *mnt, struct dentry *dentry, int level);

int ovl_indexdir_cleanup(struct ovl_fs *ofs);
@@ -673,8 +673,8 @@ struct dentry *ovl_create_temp(struct ovl_fs *ofs, struct dentry *workdir, 
extern const struct file_operations ovl_file_operations;

int __init ovl_aio_request_cache_init(void);

void ovl_aio_request_cache_destroy(void);

int ovl_real_fileattr_get(struct path *realpath, struct fileattr *fa);

int ovl_real_fileattr_set(struct path *realpath, struct fileattr *fa);

int ovl_real_fileattr_get(const struct path *realpath, struct fileattr *fa);

int ovl_real_fileattr_set(const struct path *realpath, struct fileattr *fa);

int ovl_fileattr_get(struct dentry *dentry, struct fileattr *fa);

int ovl_fileattr_set(struct user_namespace *mnt_userns,

		     struct dentry *dentry, struct fileattr *fa);
@@ -683,7 +683,7 @@ int ovl_fileattr_set(struct user_namespace *mnt_userns, 
int ovl_copy_up(struct dentry *dentry);

int ovl_copy_up_with_data(struct dentry *dentry);

int ovl_maybe_copy_up(struct dentry *dentry, int flags);

int ovl_copy_xattr(struct super_block *sb, struct path *path, struct dentry *new);

int ovl_copy_xattr(struct super_block *sb, const struct path *path, struct dentry *new);

int ovl_set_attr(struct ovl_fs *ofs, struct dentry *upper, struct kstat *stat);

struct ovl_fh *ovl_encode_real_fh(struct ovl_fs *ofs, struct dentry *real,

				  bool is_upper);