Commit 2e5aa6cb authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe
Browse files

io_uring: flags-based creds init in queue 



Use IO_WQ_WORK_CREDS to figure out if req has creds to be used.
Since recently it should rely only on flags, but not value of
work.creds.

Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 9ba0d0c8

fs/io_uring.c

+2 −2
Original line number Diff line number Diff line
@@ -6191,7 +6191,8 @@ static void __io_queue_sqe(struct io_kiocb *req, struct io_comp_state *cs) 
again:

	linked_timeout = io_prep_linked_timeout(req);



	if ((req->flags & REQ_F_WORK_INITIALIZED) && req->work.identity->creds &&

	if ((req->flags & REQ_F_WORK_INITIALIZED) &&

	    (req->work.flags & IO_WQ_WORK_CREDS) &&

	    req->work.identity->creds != current_cred()) {

		if (old_creds)

			revert_creds(old_creds);
@@ -6199,7 +6200,6 @@ static void __io_queue_sqe(struct io_kiocb *req, struct io_comp_state *cs) 
			old_creds = NULL; /* restored original creds */

		else

			old_creds = override_creds(req->work.identity->creds);

		req->work.flags |= IO_WQ_WORK_CREDS;

	}



	ret = io_issue_sqe(req, true, cs);