Commit 2f65fcee authored by Ricardo Ribalda's avatar Ricardo Ribalda Committed by Mauro Carvalho Chehab
Browse files

media: videobuf2: Explicitly state max size of planes 



The plane size needs to be PAGE_ALIGNED, so it is not possible to have
sizes bigger than MAX_INT - PAGE_SIZE.

We already check for overflows when that happen:
 if (size < vb->planes[plane].length)
	goto free;

But it is good to explicitly state our max allowed value, in order to
align with the driver expectations.

Signed-off-by: default avatarRicardo Ribalda <ribalda@chromium.org>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent be157db0

include/media/videobuf2-core.h

+4 −2
Original line number Diff line number Diff line
@@ -154,9 +154,11 @@ struct vb2_mem_ops { 
 * @dbuf:	dma_buf - shared buffer object.

 * @dbuf_mapped:	flag to show whether dbuf is mapped or not

 * @bytesused:	number of bytes occupied by data in the plane (payload).

 * @length:	size of this plane (NOT the payload) in bytes.

 * @length:	size of this plane (NOT the payload) in bytes. The maximum

 *		valid size is MAX_UINT - PAGE_SIZE.

 * @min_length:	minimum required size of this plane (NOT the payload) in bytes.

 *		@length is always greater or equal to @min_length.

 *		@length is always greater or equal to @min_length, and like

 *		@length, it is limited to MAX_UINT - PAGE_SIZE.

 * @m:		Union with memtype-specific data.

 * @m.offset:	when memory in the associated struct vb2_buffer is

 *		%VB2_MEMORY_MMAP, equals the offset from the start of