Commit 2f67dc79 authored by James Smart's avatar James Smart Committed by Martin K. Petersen
Browse files

scsi: lpfc: Fix possible memory leak when failing to issue CMF WQE 

There is no corresponding free routine if lpfc_sli4_issue_wqe fails to
issue the CMF WQE in lpfc_issue_cmf_sync_wqe.

If ret_val is non-zero, then free the iocbq request structure.

Link: https://lore.kernel.org/r/20220701211425.2708-6-jsmart2021@gmail.com


Co-developed-by: default avatarJustin Tee <justin.tee@broadcom.com>
Signed-off-by: default avatarJustin Tee <justin.tee@broadcom.com>
Signed-off-by: default avatarJames Smart <jsmart2021@gmail.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 0948a9c5

drivers/scsi/lpfc/lpfc_sli.c

+3 −1
Original line number Diff line number Diff line
@@ -2003,10 +2003,12 @@ lpfc_issue_cmf_sync_wqe(struct lpfc_hba *phba, u32 ms, u64 total) 








	sync_buf->cmd_flag |= LPFC_IO_CMF;









	ret_val = lpfc_sli4_issue_wqe(phba, &phba->sli4_hba.hdwq[0], sync_buf);









	if (ret_val)









	if (ret_val) {









		lpfc_printf_log(phba, KERN_INFO, LOG_CGN_MGMT,









				"6214 Cannot issue CMF_SYNC_WQE: x%x\n",









				ret_val);









		__lpfc_sli_release_iocbq(phba, sync_buf);









	}









out_unlock:









	spin_unlock_irqrestore(&phba->hbalock, iflags);









	return ret_val;