Commit 318c66d4 authored by Tim Collier's avatar Tim Collier Committed by Greg Kroah-Hartman
Browse files

staging: wlan-ng: remove volatile from reapable field in hfa384x_usbctlx 



Fix checkpatch.pl warning:

"Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rs"

reapable is not used to access h/w directly, so volatile is not
necessary.

>From reading the code, the contexts in which the field may be
updated/accessed across threads are protected by the hw->ctlxq.lock
spinlock, where hw is the device struct, so appears thread-safe.

Signed-off-by: default avatarTim Collier <osdevtc@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d3094361

drivers/staging/wlan-ng/hfa384x.h

+1 −1
Original line number Diff line number Diff line
@@ -1176,7 +1176,7 @@ struct hfa384x_usbctlx { 
	enum ctlx_state state;	/* Tracks running state */



	struct completion done;

	volatile int reapable;	/* Food for the reaper task */

	int reapable;		/* Food for the reaper task */



	ctlx_cmdcb_t cmdcb;	/* Async command callback */

	ctlx_usercb_t usercb;	/* Async user callback, */