Commit 33902009 authored by Dan Carpenter's avatar Dan Carpenter Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: Fix end of loop test 



This loop will exit successfully when "found" is false or in the failure
case it times out with "wait_iter" set to -1.  The test for timeouts is
impossible as is.

Fixes: b843adde ("scsi: qla2xxx: Fix mem access after free")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/cea5a62f-b873-4347-8f8e-c67527ced8d2@kili.mountain


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 8b566edb

drivers/scsi/qla2xxx/qla_os.c

+1 −1
Original line number Diff line number Diff line
@@ -1409,7 +1409,7 @@ __qla2x00_eh_wait_for_pending_commands(struct qla_qpair *qpair, unsigned int t, 
			break;

	}



	if (!wait_iter && found)

	if (wait_iter == -1)

		status = QLA_FUNCTION_FAILED;



	return status;