Commit 34bdb981 authored by Tobias Klauser's avatar Tobias Klauser Committed by Greg Kroah-Hartman
Browse files

staging: vt6656: Remove unnecesssary NULL check 



pFifoHead points to tx_buffer->fifo_head which can never be NULL.
We also don't need to check for tx_buffer being NULL instead, since it
always points to ->Data of struct vnt_usb_send_context - the pointer to
which was checked before calling s_vGenerateTxParameter().

Silences a dereference before NULL check warning reported by the coverity
scanner in CID 1127221.

Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarTobias Klauser <tklauser@distanz.ch>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 91ed9a7c

drivers/staging/vt6656/rxtx.c

+0 −3
Original line number Diff line number Diff line
@@ -813,9 +813,6 @@ static u16 s_vGenerateTxParameter(struct vnt_private *pDevice, 
	else if (wFifoCtl & FIFOCTL_AUTO_FB_1)

		byFBOption = AUTO_FB_1;



	if (!pFifoHead)

		return 0;



	if (byPktType == PK_TYPE_11GB || byPktType == PK_TYPE_11GA) {

		if (need_rts) {

			struct vnt_rrv_time_rts *pBuf =