Commit 350bef81 authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Greg Kroah-Hartman
Browse files

staging: rts5208: Remove unnecessary synchronize_irq() before free_irq() 



Calling synchronize_irq() right before free_irq() is quite useless. On one
hand the IRQ can easily fire again before free_irq() is entered, on the
other hand free_irq() itself calls synchronize_irq() internally (in a race
condition free way), before any state associated with the IRQ is freed.

Patch was generated using the following semantic patch:
// <smpl>
@@
expression irq;
@@
-synchronize_irq(irq);
 free_irq(irq, ...);
// </smpl>

Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9045a4a7

drivers/staging/rts5208/rtsx.c

+0 −2
Original line number Diff line number Diff line
@@ -320,7 +320,6 @@ static int rtsx_suspend(struct pci_dev *pci, pm_message_t state) 
	rtsx_do_before_power_down(chip, PM_S3);



	if (dev->irq >= 0) {

		synchronize_irq(dev->irq);

		free_irq(dev->irq, (void *)dev);

		dev->irq = -1;

	}
@@ -398,7 +397,6 @@ static void rtsx_shutdown(struct pci_dev *pci) 
	rtsx_do_before_power_down(chip, PM_S1);



	if (dev->irq >= 0) {

		synchronize_irq(dev->irq);

		free_irq(dev->irq, (void *)dev);

		dev->irq = -1;

	}