Commit 36c4b536 authored by Phillip Potter's avatar Phillip Potter Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: convert DBG_88E calls in core/rtw_ieee80211.c 



Convert the DBG_88E macro calls in core/rtw_ieee80211.c to use pr_debug
as their information may be useful to observers, and this gets the
driver closer to the point of being able to remove DBG_88E itself.

These calls are at points in the call chain where use of dev_dbg or
netdev_dbg isn't possible due to lack of device pointer, so plain
pr_debug is appropriate here.

Signed-off-by: default avatarPhillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20220110090020.6800-2-phil@philpotter.co.uk


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 56a9847a

drivers/staging/r8188eu/core/rtw_ieee80211.c

+18 −18
Original line number Diff line number Diff line
@@ -655,7 +655,7 @@ static int rtw_ieee802_11_parse_vendor_specific(u8 *pos, uint elen, 
	 * sub-type. */

	if (elen < 4) {

		if (show_errors) {

			DBG_88E("short vendor specific information element ignored (len=%lu)\n",

			pr_debug("short vendor specific information element ignored (len=%lu)\n",

				 (unsigned long)elen);

		}

		return -1;
@@ -675,7 +675,7 @@ static int rtw_ieee802_11_parse_vendor_specific(u8 *pos, uint elen, 
			break;

		case WME_OUI_TYPE: /* this is a Wi-Fi WME info. element */

			if (elen < 5) {

				DBG_88E("short WME information element ignored (len=%lu)\n",

				pr_debug("short WME information element ignored (len=%lu)\n",

					 (unsigned long)elen);

				return -1;

			}
@@ -690,7 +690,7 @@ static int rtw_ieee802_11_parse_vendor_specific(u8 *pos, uint elen, 
				elems->wme_tspec_len = elen;

				break;

			default:

				DBG_88E("unknown WME information element ignored (subtype=%d len=%lu)\n",

				pr_debug("unknown WME information element ignored (subtype=%d len=%lu)\n",

					 pos[4], (unsigned long)elen);

				return -1;

			}
@@ -701,7 +701,7 @@ static int rtw_ieee802_11_parse_vendor_specific(u8 *pos, uint elen, 
			elems->wps_ie_len = elen;

			break;

		default:

			DBG_88E("Unknown Microsoft information element ignored (type=%d len=%lu)\n",

			pr_debug("Unknown Microsoft information element ignored (type=%d len=%lu)\n",

				 pos[3], (unsigned long)elen);

			return -1;

		}
@@ -714,13 +714,13 @@ static int rtw_ieee802_11_parse_vendor_specific(u8 *pos, uint elen, 
			elems->vendor_ht_cap_len = elen;

			break;

		default:

			DBG_88E("Unknown Broadcom information element ignored (type=%d len=%lu)\n",

			pr_debug("Unknown Broadcom information element ignored (type=%d len=%lu)\n",

				 pos[3], (unsigned long)elen);

			return -1;

		}

		break;

	default:

		DBG_88E("unknown vendor specific information element ignored (vendor OUI %02x:%02x:%02x len=%lu)\n",

		pr_debug("unknown vendor specific information element ignored (vendor OUI %02x:%02x:%02x len=%lu)\n",

			 pos[0], pos[1], pos[2], (unsigned long)elen);

		return -1;

	}
@@ -754,7 +754,7 @@ enum parse_res rtw_ieee802_11_parse_elems(u8 *start, uint len, 


		if (elen > left) {

			if (show_errors) {

				DBG_88E("IEEE 802.11 element parse failed (id=%d elen=%d left=%lu)\n",

				pr_debug("IEEE 802.11 element parse failed (id=%d elen=%d left=%lu)\n",

					 id, elen, (unsigned long)left);

			}

			return ParseFailed;
@@ -841,7 +841,7 @@ enum parse_res rtw_ieee802_11_parse_elems(u8 *start, uint len, 
			unknown++;

			if (!show_errors)

				break;

			DBG_88E("IEEE 802.11 element parse ignored unknown element (id=%d elen=%d)\n",

			pr_debug("IEEE 802.11 element parse ignored unknown element (id=%d elen=%d)\n",

				 id, elen);

			break;

		}
@@ -892,10 +892,10 @@ void rtw_macaddr_cfg(u8 *mac_addr) 


	if (is_broadcast_ether_addr(mac) || is_zero_ether_addr(mac)) {

		eth_random_addr(mac_addr);

		DBG_88E("MAC Address from efuse error, assign random one !!!\n");

		pr_debug("MAC Address from efuse error, assign random one !!!\n");

	}



	DBG_88E("rtw_macaddr_cfg MAC Address  = %pM\n", mac_addr);

	pr_debug("MAC Address = %pM\n", mac_addr);

}



/**