Commit 37360632 authored by Chuhong Yuan's avatar Chuhong Yuan Committed by Mauro Carvalho Chehab
Browse files

media: pxa_camera: add missed tasklet_kill 



This driver forgets to kill tasklet when probe fails and remove.
Add the calls to fix it.

Signed-off-by: default avatarChuhong Yuan <hslester96@gmail.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 7b575b6d

drivers/media/platform/pxa_camera.c

+2 −0
Original line number Diff line number Diff line
@@ -2530,6 +2530,7 @@ static int pxa_camera_probe(struct platform_device *pdev) 
	v4l2_device_unregister(&pcdev->v4l2_dev);

exit_deactivate:

	pxa_camera_deactivate(pcdev);

	tasklet_kill(&pcdev->task_eof);

exit_free_dma:

	dma_release_channel(pcdev->dma_chans[2]);

exit_free_dma_u:
@@ -2544,6 +2545,7 @@ static int pxa_camera_remove(struct platform_device *pdev) 
	struct pxa_camera_dev *pcdev = dev_get_drvdata(&pdev->dev);



	pxa_camera_deactivate(pcdev);

	tasklet_kill(&pcdev->task_eof);

	dma_release_channel(pcdev->dma_chans[0]);

	dma_release_channel(pcdev->dma_chans[1]);

	dma_release_channel(pcdev->dma_chans[2]);