Commit 37900851 authored by Alexander Egorenkov's avatar Alexander Egorenkov Committed by Heiko Carstens
Browse files

watchdog: diag288_wdt: de-duplicate diag_stat_inc() calls 



Call diag_stat_inc() from __diag288() to reduce code duplication.

Reviewed-by: default avatarHeiko Carstens <hca@linux.ibm.com>
Signed-off-by: default avatarAlexander Egorenkov <egorenar@linux.ibm.com>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20230203073958.1585738-5-egorenar@linux.ibm.com


Signed-off-by: default avatarHeiko Carstens <hca@linux.ibm.com>
parent 221f748a

drivers/watchdog/diag288_wdt.c

+3 −8
Original line number Diff line number Diff line
@@ -78,6 +78,8 @@ static int __diag288(unsigned int func, unsigned int timeout, 
	union register_pair r3 = { .even = action, .odd = len, };

	int err;



	diag_stat_inc(DIAG_STAT_X288);



	err = -EINVAL;

	asm volatile(

		"	diag	%[r1],%[r3],0x288\n"
@@ -100,14 +102,12 @@ static int __diag288_vm(unsigned int func, unsigned int timeout, char *cmd) 
	ASCEBC(cmd_buf, MAX_CMDLEN);

	EBC_TOUPPER(cmd_buf, MAX_CMDLEN);



	diag_stat_inc(DIAG_STAT_X288);

	return __diag288(func, timeout, virt_to_phys(cmd_buf), len);

}



static int __diag288_lpar(unsigned int func, unsigned int timeout,

			  unsigned long action)

{

	diag_stat_inc(DIAG_STAT_X288);

	return __diag288(func, timeout, action, 0);

}
@@ -135,12 +135,7 @@ static int wdt_start(struct watchdog_device *dev) 


static int wdt_stop(struct watchdog_device *dev)

{

	int ret;



	diag_stat_inc(DIAG_STAT_X288);

	ret = __diag288(WDT_FUNC_CANCEL, 0, 0, 0);



	return ret;

	return __diag288(WDT_FUNC_CANCEL, 0, 0, 0);

}



static int wdt_ping(struct watchdog_device *dev)