Commit 37be2f1b authored by Phillip Potter's avatar Phillip Potter Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: remove rtw_hal_c2h_handler function 



Remove rtw_hal_c2h_handler function from hal/hal_intf.c, as well as its
declaration in include/hal_intf.h, and remove its one remaining caller
within core/rtw_cmd.c.

This function was a wrapper function, then simplified to always return
_FAIL. Since it has no further use, remove it, as part of ongoing
efforts to simplify and remove the HAL layer of the driver.

Acked-by: default avatarFabio M. De Francesco <fmdefrancesco@gmail.com>
Acked-by: default avatarMichael Straube <straube.linux@gmail.com>
Signed-off-by: default avatarPhillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20210829234541.946-4-phil@philpotter.co.uk


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9c275897

drivers/staging/r8188eu/core/rtw_cmd.c

+0 −2
Original line number Diff line number Diff line
@@ -1896,8 +1896,6 @@ static void c2h_wk_callback(struct work_struct *work) 
		}



		if (ccx_id_filter(c2h_evt->id)) {

			/* Handle CCX report here */

			rtw_hal_c2h_handler(adapter, c2h_evt);

			kfree(c2h_evt);

		} else {

#ifdef CONFIG_88EU_P2P

drivers/staging/r8188eu/hal/hal_intf.c

+0 −5
Original line number Diff line number Diff line
@@ -426,11 +426,6 @@ void rtw_hal_reset_security_engine(struct adapter *adapter) 
		adapter->HalFunc.hal_reset_security_engine(adapter);

}



s32 rtw_hal_c2h_handler(struct adapter *adapter, struct c2h_evt_hdr *c2h_evt)

{

	return _FAIL;

}



c2h_id_filter rtw_hal_c2h_id_filter_ccx(struct adapter *adapter)

{

	return adapter->HalFunc.c2h_id_filter_ccx;

drivers/staging/r8188eu/include/hal_intf.h

+0 −2
Original line number Diff line number Diff line
@@ -400,8 +400,6 @@ int rtw_hal_iol_cmd(struct adapter *adapter, struct xmit_frame *xmit_frame, 
void rtw_hal_notch_filter(struct adapter *adapter, bool enable);

void rtw_hal_reset_security_engine(struct adapter *adapter);



s32 rtw_hal_c2h_handler(struct adapter *adapter,

			struct c2h_evt_hdr *c2h_evt);

c2h_id_filter rtw_hal_c2h_id_filter_ccx(struct adapter *adapter);

void indicate_wx_scan_complete_event(struct adapter *padapter);

u8 rtw_do_join(struct adapter *padapter);