Commit 3806a8c6 authored by Icenowy Zheng's avatar Icenowy Zheng Committed by Alex Deucher
Browse files

drm/amdgpu: fix SI failure due to doorbells allocation 



SI hardware does not have doorbells at all, however currently the code
will try to do the allocation and thus fail, makes SI AMDGPU not usable.

Fix this failure by skipping doorbells allocation when doorbells count
is zero.

Fixes: 54c30d2a ("drm/amdgpu: create kernel doorbell pages")
Reviewed-by: default avatarShashank Sharma <shashank.sharma@amd.com>
Signed-off-by: default avatarIcenowy Zheng <uwu@icenowy.me>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent ff89f064

drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c

+4 −0
Original line number Diff line number Diff line
@@ -142,6 +142,10 @@ int amdgpu_doorbell_create_kernel_doorbells(struct amdgpu_device *adev) 
	int r;

	int size;



	/* SI HW does not have doorbells, skip allocation */

	if (adev->doorbell.num_kernel_doorbells == 0)

		return 0;



	/* Reserve first num_kernel_doorbells (page-aligned) for kernel ops */

	size = ALIGN(adev->doorbell.num_kernel_doorbells * sizeof(u32), PAGE_SIZE);