Commit 394e80c8 authored by Cai Huoqing's avatar Cai Huoqing Committed by Helge Deller
Browse files

video: fbdev: da8xx-fb: Make use of the helper function dev_err_probe() 



When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: default avatarCai Huoqing <caihuoqing@baidu.com>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent 0d3dbeb8

drivers/video/fbdev/da8xx-fb.c

+3 −4
Original line number Original line Diff line number Diff line
@@ -1354,10 +1354,9 @@ static int fb_probe(struct platform_device *device) 
		return PTR_ERR(da8xx_fb_reg_base);

		return PTR_ERR(da8xx_fb_reg_base);





	tmp_lcdc_clk = devm_clk_get(&device->dev, "fck");

	tmp_lcdc_clk = devm_clk_get(&device->dev, "fck");

	if (IS_ERR(tmp_lcdc_clk)) {

	if (IS_ERR(tmp_lcdc_clk))

		dev_err(&device->dev, "Can not get device clock\n");

		return dev_err_probe(&device->dev, PTR_ERR(tmp_lcdc_clk),

		return PTR_ERR(tmp_lcdc_clk);

				     "Can not get device clock\n");

	}





	pm_runtime_enable(&device->dev);

	pm_runtime_enable(&device->dev);

	pm_runtime_get_sync(&device->dev);

	pm_runtime_get_sync(&device->dev);