Commit 396dd2c0 authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: acornscsi: Call scsi_done() directly 

Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.

Link: https://lore.kernel.org/r/20211007202923.2174984-18-bvanassche@acm.org


Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 7afdb863

drivers/scsi/arm/acornscsi.c

+1 −5
Original line number Diff line number Diff line
@@ -841,13 +841,10 @@ static void acornscsi_done(AS_Host *host, struct scsi_cmnd **SCpntp, 
		}

	}



	if (!SCpnt->scsi_done)

	    panic("scsi%d.H: null scsi_done function in acornscsi_done", host->host->host_no);



	clear_bit(SCpnt->device->id * 8 +

		  (u8)(SCpnt->device->lun & 0x7), host->busyluns);



	SCpnt->scsi_done(SCpnt);

	scsi_done(SCpnt);

    } else

	printk("scsi%d: null command in acornscsi_done", host->host->host_no);
@@ -2428,7 +2425,6 @@ static int acornscsi_queuecmd_lck(struct scsi_cmnd *SCpnt, 
    }

#endif



    SCpnt->scsi_done = done;

    SCpnt->host_scribble = NULL;

    SCpnt->result = 0;

    SCpnt->SCp.phase = (int)acornscsi_datadirection(SCpnt->cmnd[0]);