Commit 3a20e642 authored by Xiang Chen's avatar Xiang Chen Committed by Martin K. Petersen
Browse files

scsi: libsas: Remove unused parameter for function sas_ata_eh() 

Input parameter work_q is not unused in function sas_ata_eh(), so remove
it.

Link: https://lore.kernel.org/r/1644561778-183074-4-git-send-email-chenxiang66@hisilicon.com


Reviewed-by: default avatarJohn Garry <john.garry@huawei.com>
Signed-off-by: default avatarXiang Chen <chenxiang66@hisilicon.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 59803ccb

drivers/scsi/libsas/sas_ata.c

+1 −2
Original line number Diff line number Diff line
@@ -782,8 +782,7 @@ void sas_ata_strategy_handler(struct Scsi_Host *shost) 
	sas_enable_revalidation(sas_ha);

}



void sas_ata_eh(struct Scsi_Host *shost, struct list_head *work_q,

		struct list_head *done_q)

void sas_ata_eh(struct Scsi_Host *shost, struct list_head *work_q)

{

	struct scsi_cmnd *cmd, *n;

	struct domain_device *eh_dev;

drivers/scsi/libsas/sas_scsi_host.c

+1 −1
Original line number Diff line number Diff line
@@ -757,7 +757,7 @@ void sas_scsi_recover_host(struct Scsi_Host *shost) 
	 * scsi_unjam_host does, but we skip scsi_eh_abort_cmds because any

	 * command we see here has no sas_task and is thus unknown to the HA.

	 */

	sas_ata_eh(shost, &eh_work_q, &ha->eh_done_q);

	sas_ata_eh(shost, &eh_work_q);

	if (!scsi_eh_get_sense(&eh_work_q, &ha->eh_done_q))

		scsi_eh_ready_devs(shost, &eh_work_q, &ha->eh_done_q);

include/scsi/sas_ata.h

+2 −4
Original line number Diff line number Diff line
@@ -25,8 +25,7 @@ int sas_get_ata_info(struct domain_device *dev, struct ex_phy *phy); 
int sas_ata_init(struct domain_device *dev);

void sas_ata_task_abort(struct sas_task *task);

void sas_ata_strategy_handler(struct Scsi_Host *shost);

void sas_ata_eh(struct Scsi_Host *shost, struct list_head *work_q,

		struct list_head *done_q);

void sas_ata_eh(struct Scsi_Host *shost, struct list_head *work_q);

void sas_ata_schedule_reset(struct domain_device *dev);

void sas_ata_wait_eh(struct domain_device *dev);

void sas_probe_sata(struct asd_sas_port *port);
@@ -52,8 +51,7 @@ static inline void sas_ata_strategy_handler(struct Scsi_Host *shost) 
{

}



static inline void sas_ata_eh(struct Scsi_Host *shost, struct list_head *work_q,

			      struct list_head *done_q)

static inline void sas_ata_eh(struct Scsi_Host *shost, struct list_head *work_q)

{

}