Commit 3c01b054 authored by Rob Herring's avatar Rob Herring Committed by Florian Fainelli
Browse files

ARM: bcm: Use of_address_to_resource() 



Replace open coded parsing of "reg" with of_address_to_resource().

Signed-off-by: default avatarRob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20230319163125.224833-1-robh@kernel.org


Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
parent fe15c26e

arch/arm/mach-bcm/bcm_kona_smc.c

+6 −17
Original line number Diff line number Diff line
@@ -31,34 +31,23 @@ static const struct of_device_id bcm_kona_smc_ids[] __initconst = { 
int __init bcm_kona_smc_init(void)

{

	struct device_node *node;

	const __be32 *prop_val;

	u64 prop_size = 0;

	unsigned long buffer_size;

	u32 buffer_phys;

	struct resource res;

	int ret;



	/* Read buffer addr and size from the device tree node */

	node = of_find_matching_node(NULL, bcm_kona_smc_ids);

	if (!node)

		return -ENODEV;



	prop_val = of_get_address(node, 0, &prop_size, NULL);

	ret = of_address_to_resource(node, 0, &res);

	of_node_put(node);

	if (!prop_val)

	if (ret)

		return -EINVAL;



	/* We assume space for four 32-bit arguments */

	if (prop_size < 4 * sizeof(u32) || prop_size > (u64)ULONG_MAX)

		return -EINVAL;

	buffer_size = (unsigned long)prop_size;



	buffer_phys = be32_to_cpup(prop_val);

	if (!buffer_phys)

		return -EINVAL;



	bcm_smc_buffer = ioremap(buffer_phys, buffer_size);

	bcm_smc_buffer = ioremap(res.start, resource_size(&res));

	if (!bcm_smc_buffer)

		return -ENOMEM;

	bcm_smc_buffer_phys = buffer_phys;

	bcm_smc_buffer_phys = res.start;



	pr_info("Kona Secure API initialized\n");