Commit 3dd4d40b authored Oct 23, 2019 by Jan Kara Committed by Darrick J. Wong Oct 24, 2019

xfs: Sanity check flags of Q_XQUOTARM call



Flags passed to Q_XQUOTARM were not sanity checked for invalid values.
Fix that.

Fixes: 9da93f9b ("xfs: fix Q_XQUOTARM ioctl")
Reported-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

parent 1aa63006

fs/xfs/xfs_quotaops.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -201,6 +201,9 @@ xfs_fs_rm_xquota(
		if (XFS_IS_QUOTA_ON(mp))
		return -EINVAL;

		if (uflags & ~(FS_USER_QUOTA \| FS_GROUP_QUOTA \| FS_PROJ_QUOTA))
		return -EINVAL;

		if (uflags & FS_USER_QUOTA)
		flags \|= XFS_DQ_USER;
		if (uflags & FS_GROUP_QUOTA)