Unverified Commit 3e2649c5 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Mark Brown
Browse files

ASoC: samsung: Fix error handling in aries_audio_probe 



of_get_child_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
This function is missing of_node_put(cpu) in the error path.
Fix this by goto out label. of_node_put() will check NULL pointer.

Fixes: 7a3a7671 ("ASoC: samsung: Add driver for Aries boards")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20220603130640.37624-1-linmq006@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 0a034d93

sound/soc/samsung/aries_wm8994.c

+4 −2
Original line number Diff line number Diff line
@@ -628,8 +628,10 @@ static int aries_audio_probe(struct platform_device *pdev) 
		return -EINVAL;



	codec = of_get_child_by_name(dev->of_node, "codec");

	if (!codec)

		return -EINVAL;

	if (!codec) {

		ret = -EINVAL;

		goto out;

	}



	for_each_card_prelinks(card, i, dai_link) {

		dai_link->codecs->of_node = of_parse_phandle(codec,