Commit 3e4273db authored Dec 22, 2016 by David Binder Committed by Greg Kroah-Hartman Jan 03, 2017

staging: unisys: visorbus: Remove unneeded checks for valid variable addr

The 'retry' variable created in handle_command() is statically allocated,
and its address is never set to NULL. Therefore conditionals to verify
the validity of the retry variable's address are unnecessary.

Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Binder <david.binder@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 36309d3b

drivers/staging/unisys/visorbus/visorchipset.c

+3 −6

Original line number	Diff line number	Diff line
		@@ -1852,7 +1852,6 @@ parser_init_byte_stream(u64 addr, u32 bytes, bool local, bool *retry)
		int allocbytes = sizeof(struct parser_context) + bytes;
		struct parser_context *ctx;

		if (retry)
		*retry = false;

		/*
		@@ -1862,13 +1861,11 @@ parser_init_byte_stream(u64 addr, u32 bytes, bool local, bool *retry)
		allocbytes++;
		if ((controlvm_payload_bytes_buffered + bytes)
		> MAX_CONTROLVM_PAYLOAD_BYTES) {
		if (retry)
		*retry = true;
		return NULL;
		}
		ctx = kzalloc(allocbytes, GFP_KERNEL \| __GFP_NORETRY);
		if (!ctx) {
		if (retry)
		*retry = true;
		return NULL;
		}