Commit 3e438b42 authored by Tomer Tayar's avatar Tomer Tayar Committed by Oded Gabbay
Browse files

habanalabs: Add mask for CS type bits in CS flags 



hl_cs_sanity_checks() extracts the CS type bits of the CS flags, by
masking out the non-type bits.
To save the need for updating the function whenever new bits for
non-type flags are added, add an explicit mask for the CS type bits.

Signed-off-by: default avatarTomer Tayar <ttayar@habana.ai>
Reviewed-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
parent 3b82c34f

drivers/misc/habanalabs/common/command_submission.c

+4 −2
Original line number Diff line number Diff line
@@ -11,6 +11,9 @@ 
#include <linux/uaccess.h>

#include <linux/slab.h>



#define HL_CS_FLAGS_TYPE_MASK	(HL_CS_FLAGS_SIGNAL | HL_CS_FLAGS_WAIT | \

				HL_CS_FLAGS_COLLECTIVE_WAIT)



/**

 * enum hl_cs_wait_status - cs wait status

 * @CS_WAIT_STATUS_BUSY: cs was not completed yet
@@ -737,8 +740,7 @@ static int hl_cs_sanity_checks(struct hl_fpriv *hpriv, union hl_cs_args *args) 
		return -EBUSY;

	}



	cs_type_flags = args->in.cs_flags &

			~(HL_CS_FLAGS_FORCE_RESTORE | HL_CS_FLAGS_TIMESTAMP);

	cs_type_flags = args->in.cs_flags & HL_CS_FLAGS_TYPE_MASK;



	if (unlikely(cs_type_flags && !is_power_of_2(cs_type_flags))) {

		dev_err(hdev->dev,