Commit 3f43926f authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Alexandre Belloni
Browse files

i3c/master/mipi-i3c-hci: Fix a potentially infinite loop in 'hci_dat_v1_get_index()' 



The code in 'hci_dat_v1_get_index()' really looks like a hand coded version
of 'for_each_set_bit()', except that a +1 is missing when searching for the
next set bit.

This really looks odd and it seems that it will loop until 'dat_w0_read()'
returns the expected result.

So use 'for_each_set_bit()' instead. It is less verbose and should be more
correct.

Fixes: 9ad9a52c ("i3c/master: introduce the mipi-i3c-hci driver")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: default avatarNicolas Pitre <npitre@baylibre.com>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/0cdf3cb10293ead1acd271fdb8a70369c298c082.1637186628.git.christophe.jaillet@wanadoo.fr
parent f18f9811

drivers/i3c/master/mipi-i3c-hci/dat_v1.c

+1 −3
Original line number Diff line number Diff line
@@ -160,9 +160,7 @@ static int hci_dat_v1_get_index(struct i3c_hci *hci, u8 dev_addr) 
	unsigned int dat_idx;

	u32 dat_w0;



	for (dat_idx = find_first_bit(hci->DAT_data, hci->DAT_entries);

	     dat_idx < hci->DAT_entries;

	     dat_idx = find_next_bit(hci->DAT_data, hci->DAT_entries, dat_idx)) {

	for_each_set_bit(dat_idx, hci->DAT_data, hci->DAT_entries) {

		dat_w0 = dat_w0_read(dat_idx);

		if (FIELD_GET(DAT_0_DYNAMIC_ADDRESS, dat_w0) == dev_addr)

			return dat_idx;