Commit 3f6dbe62 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

serial: sunsu: drop low-latency workaround 



The sunsu driver has been carrying a workaround for the infamous
low_latency behaviour of tty_flip_buffer_push() by dropping and
reacquiring the port lock in the interrupt handler since 2004.

Since commit a9c3f68f ("tty: Fix low_latency BUG"),
tty_flip_buffer_push() always schedules a work item to push data to the
line discipline and there's no need to keep any low_latency hacks around.

Cc: "David S. Miller" <davem@davemloft.net>
Acked-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20210421095509.3024-24-johan@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0f8a7328

drivers/tty/serial/sunsu.c

+0 −4
Original line number Diff line number Diff line
@@ -466,12 +466,8 @@ static irqreturn_t sunsu_serial_interrupt(int irq, void *dev_id) 
		if (status & UART_LSR_THRE)

			transmit_chars(up);



		spin_unlock_irqrestore(&up->port.lock, flags);



		tty_flip_buffer_push(&up->port.state->port);



		spin_lock_irqsave(&up->port.lock, flags);



	} while (!(serial_in(up, UART_IIR) & UART_IIR_NO_INT));



	spin_unlock_irqrestore(&up->port.lock, flags);