Commit 3f8f36da authored by Sergei Krainov's avatar Sergei Krainov Committed by Greg Kroah-Hartman
Browse files

staging: rtl8712: fix wrong function output 



Return NULL from r8712_find_network() if no matched wlan_network
was found. Code with a bug:

while (plist != phead) {
	pnetwork = container_of(plist, struct wlan_network, list);
	plist = plist->next;
	if (!memcmp(addr, pnetwork->network.MacAddress, ETH_ALEN))
		break;
}
spin_unlock_irqrestore(&scanned_queue->lock, irqL);
return pnetwork;

In this code last processed pnetwork returned if list end was reached
and no pnetwork matched test condition.

Signed-off-by: default avatarSergei Krainov <sergei.krainov.lkd@gmail.com>
Link: https://lore.kernel.org/r/20210409124611.GA3981@test-VirtualBox


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b3dffce0

drivers/staging/rtl8712/rtl871x_mlme.c

+2 −0
Original line number Diff line number Diff line
@@ -146,6 +146,8 @@ static struct wlan_network *r8712_find_network(struct __queue *scanned_queue, 
		if (!memcmp(addr, pnetwork->network.MacAddress, ETH_ALEN))

			break;

	}

	if (plist == phead)

		pnetwork = NULL;

	spin_unlock_irqrestore(&scanned_queue->lock, irqL);

	return pnetwork;

}