Commit 40430f0c authored by Bhaktipriya Shridhar's avatar Bhaktipriya Shridhar Committed by Greg Kroah-Hartman
Browse files

staging: rtl8712: Make return of 0 explicit 



Delete unnecessary local variable whose value is always 0 and
return 0 as the result.

The following Coccinelle script was used:

@@
identifier ret; expression E;
type T;
@@
(
- T ret;
|
- T ret = 0;
)

... when != \(ret=E
\|ret--\|ret++\|--ret\|++ret\|ret-=E\|ret+=E\|ret|=E\|ret&=E\)
(
?-ret = 0;
)
... when != \(ret=E
\|ret--\|ret++\|--ret\|++ret\|ret-=E\|ret+=E\|ret|=E\|ret&=E\)
(
return
- ret
+ 0
;
)

Signed-off-by: default avatarBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9155c924

drivers/staging/rtl8712/xmit_linux.c

+2 −6
Original line number Diff line number Diff line
@@ -161,19 +161,15 @@ int r8712_xmit_entry(_pkt *pkt, struct net_device *pnetdev) 
	struct xmit_frame *pxmitframe = NULL;

	struct _adapter *padapter = netdev_priv(pnetdev);

	struct xmit_priv *pxmitpriv = &(padapter->xmitpriv);

	int ret = 0;



	if (!r8712_if_up(padapter)) {

		ret = 0;

		goto _xmit_entry_drop;

	}

	pxmitframe = r8712_alloc_xmitframe(pxmitpriv);

	if (!pxmitframe) {

		ret = 0;

		goto _xmit_entry_drop;

	}

	if ((!r8712_update_attrib(padapter, pkt, &pxmitframe->attrib))) {

		ret = 0;

		goto _xmit_entry_drop;

	}

	padapter->ledpriv.LedControlHandler(padapter, LED_CTL_TX);
@@ -185,11 +181,11 @@ int r8712_xmit_entry(_pkt *pkt, struct net_device *pnetdev) 
	}

	pxmitpriv->tx_pkts++;

	pxmitpriv->tx_bytes += pxmitframe->attrib.last_txcmdsz;

	return ret;

	return 0;

_xmit_entry_drop:

	if (pxmitframe)

		r8712_free_xmitframe(pxmitpriv, pxmitframe);

	pxmitpriv->tx_drop++;

	dev_kfree_skb_any(pkt);

	return ret;

	return 0;

}