Commit 40596d2f authored by Yong Wu's avatar Yong Wu Committed by Will Deacon
Browse files

iommu/io-pgtable-arm-v7s: Extend PA34 for MediaTek 



MediaTek extend the bit5 in lvl1 and lvl2 descriptor as PA34.

Signed-off-by: default avatarYong Wu <yong.wu@mediatek.com>
Acked-by: default avatarWill Deacon <will@kernel.org>
Reviewed-by: default avatarRobin Murphy <robin.murphy@arm.com>
Reviewed-by: default avatarTomasz Figa <tfiga@chromium.org>
Link: https://lore.kernel.org/r/20210111111914.22211-11-yong.wu@mediatek.com


Signed-off-by: default avatarWill Deacon <will@kernel.org>
parent 859da211

drivers/iommu/io-pgtable-arm-v7s.c

+7 −2
Original line number Diff line number Diff line
@@ -112,9 +112,10 @@ 
#define ARM_V7S_TEX_MASK		0x7

#define ARM_V7S_ATTR_TEX(val)		(((val) & ARM_V7S_TEX_MASK) << ARM_V7S_TEX_SHIFT)



/* MediaTek extend the two bits for PA 32bit/33bit */

/* MediaTek extend the bits below for PA 32bit/33bit/34bit */

#define ARM_V7S_ATTR_MTK_PA_BIT32	BIT(9)

#define ARM_V7S_ATTR_MTK_PA_BIT33	BIT(4)

#define ARM_V7S_ATTR_MTK_PA_BIT34	BIT(5)



/* *well, except for TEX on level 2 large pages, of course :( */

#define ARM_V7S_CONT_PAGE_TEX_SHIFT	6
@@ -194,6 +195,8 @@ static arm_v7s_iopte paddr_to_iopte(phys_addr_t paddr, int lvl, 
		pte |= ARM_V7S_ATTR_MTK_PA_BIT32;

	if (paddr & BIT_ULL(33))

		pte |= ARM_V7S_ATTR_MTK_PA_BIT33;

	if (paddr & BIT_ULL(34))

		pte |= ARM_V7S_ATTR_MTK_PA_BIT34;

	return pte;

}
@@ -218,6 +221,8 @@ static phys_addr_t iopte_to_paddr(arm_v7s_iopte pte, int lvl, 
		paddr |= BIT_ULL(32);

	if (pte & ARM_V7S_ATTR_MTK_PA_BIT33)

		paddr |= BIT_ULL(33);

	if (pte & ARM_V7S_ATTR_MTK_PA_BIT34)

		paddr |= BIT_ULL(34);

	return paddr;

}
@@ -748,7 +753,7 @@ static struct io_pgtable *arm_v7s_alloc_pgtable(struct io_pgtable_cfg *cfg, 
	if (cfg->ias > ARM_V7S_ADDR_BITS)

		return NULL;



	if (cfg->oas > (arm_v7s_is_mtk_enabled(cfg) ? 34 : ARM_V7S_ADDR_BITS))

	if (cfg->oas > (arm_v7s_is_mtk_enabled(cfg) ? 35 : ARM_V7S_ADDR_BITS))

		return NULL;



	if (cfg->quirks & ~(IO_PGTABLE_QUIRK_ARM_NS |

drivers/iommu/mtk_iommu.c

+1 −1
Original line number Diff line number Diff line
@@ -300,7 +300,7 @@ static int mtk_iommu_domain_finalise(struct mtk_iommu_domain *dom) 
			IO_PGTABLE_QUIRK_ARM_MTK_EXT,

		.pgsize_bitmap = mtk_iommu_ops.pgsize_bitmap,

		.ias = 32,

		.oas = 34,

		.oas = 35,

		.iommu_dev = data->dev,

	};

include/linux/io-pgtable.h

+2 −2
Original line number Diff line number Diff line
@@ -69,8 +69,8 @@ struct io_pgtable_cfg { 
	 *	format, and/or requires some format-specific default value.

	 *

	 * IO_PGTABLE_QUIRK_ARM_MTK_EXT: (ARM v7s format) MediaTek IOMMUs extend

	 *	to support up to 34 bits PA where the bit32 and bit33 are

	 *	encoded in the bit9 and bit4 of the PTE respectively.

	 *	to support up to 35 bits PA where the bit32, bit33 and bit34 are

	 *	encoded in the bit9, bit4 and bit5 of the PTE respectively.

	 *

	 * IO_PGTABLE_QUIRK_NON_STRICT: Skip issuing synchronous leaf TLBIs

	 *	on unmap, for DMA domains using the flush queue mechanism for