Commit 4154a4f7 authored by Rikard Falkeborn's avatar Rikard Falkeborn Committed by Greg Kroah-Hartman
Browse files

USB: core: Constify static attribute_group structs 



These are never modified, so make them const to allow the compiler to
put them in read-only memory. Done with the help of coccinelle.

Signed-off-by: default avatarRikard Falkeborn <rikard.falkeborn@gmail.com>
Link: https://lore.kernel.org/r/20201125162500.37228-2-rikard.falkeborn@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 11e5e568

drivers/usb/core/endpoint.c

+1 −1
Original line number Diff line number Diff line
@@ -153,7 +153,7 @@ static struct attribute *ep_dev_attrs[] = { 
	&dev_attr_direction.attr,

	NULL,

};

static struct attribute_group ep_dev_attr_grp = {

static const struct attribute_group ep_dev_attr_grp = {

	.attrs = ep_dev_attrs,

};

static const struct attribute_group *ep_dev_groups[] = {

drivers/usb/core/port.c

+2 −2
Original line number Diff line number Diff line
@@ -155,7 +155,7 @@ static struct attribute *port_dev_attrs[] = { 
	NULL,

};



static struct attribute_group port_dev_attr_grp = {

static const struct attribute_group port_dev_attr_grp = {

	.attrs = port_dev_attrs,

};
@@ -169,7 +169,7 @@ static struct attribute *port_dev_usb3_attrs[] = { 
	NULL,

};



static struct attribute_group port_dev_usb3_attr_grp = {

static const struct attribute_group port_dev_usb3_attr_grp = {

	.attrs = port_dev_usb3_attrs,

};

drivers/usb/core/sysfs.c

+7 −7
Original line number Diff line number Diff line
@@ -641,7 +641,7 @@ static struct attribute *usb2_hardware_lpm_attr[] = { 
	&dev_attr_usb2_lpm_besl.attr,

	NULL,

};

static struct attribute_group usb2_hardware_lpm_attr_group = {

static const struct attribute_group usb2_hardware_lpm_attr_group = {

	.name	= power_group_name,

	.attrs	= usb2_hardware_lpm_attr,

};
@@ -651,7 +651,7 @@ static struct attribute *usb3_hardware_lpm_attr[] = { 
	&dev_attr_usb3_hardware_lpm_u2.attr,

	NULL,

};

static struct attribute_group usb3_hardware_lpm_attr_group = {

static const struct attribute_group usb3_hardware_lpm_attr_group = {

	.name	= power_group_name,

	.attrs	= usb3_hardware_lpm_attr,

};
@@ -663,7 +663,7 @@ static struct attribute *power_attrs[] = { 
	&dev_attr_active_duration.attr,

	NULL,

};

static struct attribute_group power_attr_group = {

static const struct attribute_group power_attr_group = {

	.name	= power_group_name,

	.attrs	= power_attrs,

};
@@ -832,7 +832,7 @@ static struct attribute *dev_attrs[] = { 
#endif

	NULL,

};

static struct attribute_group dev_attr_grp = {

static const struct attribute_group dev_attr_grp = {

	.attrs = dev_attrs,

};
@@ -865,7 +865,7 @@ static umode_t dev_string_attrs_are_visible(struct kobject *kobj, 
	return a->mode;

}



static struct attribute_group dev_string_attr_grp = {

static const struct attribute_group dev_string_attr_grp = {

	.attrs =	dev_string_attrs,

	.is_visible =	dev_string_attrs_are_visible,

};
@@ -1222,7 +1222,7 @@ static struct attribute *intf_attrs[] = { 
	&dev_attr_interface_authorized.attr,

	NULL,

};

static struct attribute_group intf_attr_grp = {

static const struct attribute_group intf_attr_grp = {

	.attrs = intf_attrs,

};
@@ -1246,7 +1246,7 @@ static umode_t intf_assoc_attrs_are_visible(struct kobject *kobj, 
	return a->mode;

}



static struct attribute_group intf_assoc_attr_grp = {

static const struct attribute_group intf_assoc_attr_grp = {

	.attrs =	intf_assoc_attrs,

	.is_visible =	intf_assoc_attrs_are_visible,

};