Commit 415a0484 authored by Li Zhijian's avatar Li Zhijian Committed by Leon Romanovsky
Browse files

RDMA/rxe: convert pr_warn to pr_debug 



They could be triggered by user APIs with invalid parameters.

Signed-off-by: default avatarLi Zhijian <lizhijian@fujitsu.com>
Link: https://lore.kernel.org/r/1662518901-2-2-git-send-email-lizhijian@fujitsu.com


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent e2edba67

drivers/infiniband/sw/rxe/rxe_qp.c

+22 −23
Original line number Diff line number Diff line
@@ -19,33 +19,33 @@ static int rxe_qp_chk_cap(struct rxe_dev *rxe, struct ib_qp_cap *cap, 
			  int has_srq)

{

	if (cap->max_send_wr > rxe->attr.max_qp_wr) {

		pr_warn("invalid send wr = %u > %d\n",

		pr_debug("invalid send wr = %u > %d\n",

			 cap->max_send_wr, rxe->attr.max_qp_wr);

		goto err1;

	}



	if (cap->max_send_sge > rxe->attr.max_send_sge) {

		pr_warn("invalid send sge = %u > %d\n",

		pr_debug("invalid send sge = %u > %d\n",

			 cap->max_send_sge, rxe->attr.max_send_sge);

		goto err1;

	}



	if (!has_srq) {

		if (cap->max_recv_wr > rxe->attr.max_qp_wr) {

			pr_warn("invalid recv wr = %u > %d\n",

			pr_debug("invalid recv wr = %u > %d\n",

				 cap->max_recv_wr, rxe->attr.max_qp_wr);

			goto err1;

		}



		if (cap->max_recv_sge > rxe->attr.max_recv_sge) {

			pr_warn("invalid recv sge = %u > %d\n",

			pr_debug("invalid recv sge = %u > %d\n",

				 cap->max_recv_sge, rxe->attr.max_recv_sge);

			goto err1;

		}

	}



	if (cap->max_inline_data > rxe->max_inline_data) {

		pr_warn("invalid max inline data = %u > %d\n",

		pr_debug("invalid max inline data = %u > %d\n",

			 cap->max_inline_data, rxe->max_inline_data);

		goto err1;

	}
@@ -73,7 +73,7 @@ int rxe_qp_chk_init(struct rxe_dev *rxe, struct ib_qp_init_attr *init) 
	}



	if (!init->recv_cq || !init->send_cq) {

		pr_warn("missing cq\n");

		pr_debug("missing cq\n");

		goto err1;

	}
@@ -82,14 +82,14 @@ int rxe_qp_chk_init(struct rxe_dev *rxe, struct ib_qp_init_attr *init) 


	if (init->qp_type == IB_QPT_GSI) {

		if (!rdma_is_port_valid(&rxe->ib_dev, port_num)) {

			pr_warn("invalid port = %d\n", port_num);

			pr_debug("invalid port = %d\n", port_num);

			goto err1;

		}



		port = &rxe->port;



		if (init->qp_type == IB_QPT_GSI && port->qp_gsi_index) {

			pr_warn("GSI QP exists for port %d\n", port_num);

			pr_debug("GSI QP exists for port %d\n", port_num);

			goto err1;

		}

	}
@@ -402,7 +402,7 @@ int rxe_qp_chk_attr(struct rxe_dev *rxe, struct rxe_qp *qp, 
					attr->qp_state : cur_state;



	if (!ib_modify_qp_is_ok(cur_state, new_state, qp_type(qp), mask)) {

		pr_warn("invalid mask or state for qp\n");

		pr_debug("invalid mask or state for qp\n");

		goto err1;

	}
@@ -416,7 +416,7 @@ int rxe_qp_chk_attr(struct rxe_dev *rxe, struct rxe_qp *qp, 


	if (mask & IB_QP_PORT) {

		if (!rdma_is_port_valid(&rxe->ib_dev, attr->port_num)) {

			pr_warn("invalid port %d\n", attr->port_num);

			pr_debug("invalid port %d\n", attr->port_num);

			goto err1;

		}

	}
@@ -431,11 +431,11 @@ int rxe_qp_chk_attr(struct rxe_dev *rxe, struct rxe_qp *qp, 
		if (rxe_av_chk_attr(rxe, &attr->alt_ah_attr))

			goto err1;

		if (!rdma_is_port_valid(&rxe->ib_dev, attr->alt_port_num))  {

			pr_warn("invalid alt port %d\n", attr->alt_port_num);

			pr_debug("invalid alt port %d\n", attr->alt_port_num);

			goto err1;

		}

		if (attr->alt_timeout > 31) {

			pr_warn("invalid QP alt timeout %d > 31\n",

			pr_debug("invalid QP alt timeout %d > 31\n",

				 attr->alt_timeout);

			goto err1;

		}
@@ -457,7 +457,7 @@ int rxe_qp_chk_attr(struct rxe_dev *rxe, struct rxe_qp *qp, 


	if (mask & IB_QP_MAX_QP_RD_ATOMIC) {

		if (attr->max_rd_atomic > rxe->attr.max_qp_rd_atom) {

			pr_warn("invalid max_rd_atomic %d > %d\n",

			pr_debug("invalid max_rd_atomic %d > %d\n",

				 attr->max_rd_atomic,

				 rxe->attr.max_qp_rd_atom);

			goto err1;
@@ -466,8 +466,7 @@ int rxe_qp_chk_attr(struct rxe_dev *rxe, struct rxe_qp *qp, 


	if (mask & IB_QP_TIMEOUT) {

		if (attr->timeout > 31) {

			pr_warn("invalid QP timeout %d > 31\n",

				attr->timeout);

			pr_debug("invalid QP timeout %d > 31\n", attr->timeout);

			goto err1;

		}

	}