Commit 41703684 authored by David Woodhouse's avatar David Woodhouse Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (13716): [Mantis] Bug: incorrect byte swap 



You know, the worst endianness errors are not the cases where
people forget to byte-swap, but the cases where they either byte-swap
with the wrong size, or byte-swap when they shouldn't have done so at
all. Those ones defeat the casual reader of the code.

Signed-off-by: default avatarDavid Woodhouse <dwmw2@infradead.org>
Signed-off-by: default avatarManu Abraham <manu@linuxtv.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 8154bad4

drivers/media/dvb/mantis/mantis_dma.c

+1 −1
Original line number Diff line number Diff line
@@ -189,7 +189,7 @@ void mantis_dma_start(struct mantis_pci *mantis) 
	dprintk(verbose, MANTIS_DEBUG, 1, "Mantis Start DMA engine");



	mantis_risc_program(mantis);

	mmwrite(cpu_to_le32(mantis->risc_dma), MANTIS_RISC_START);

	mmwrite(mantis->risc_dma, MANTIS_RISC_START);

	mmwrite(mmread(MANTIS_GPIF_ADDR) | MANTIS_GPIF_RDWRN, MANTIS_GPIF_ADDR);



	mmwrite(0, MANTIS_DMA_CTL);