Commit 41e5d6f6 authored by Azeem Shaikh's avatar Azeem Shaikh Committed by Martin K. Petersen
Browse files

scsi: smartpqi: Replace all non-returning strlcpy() with strscpy() 

strlcpy() reads the entire source buffer first.  This read may exceed the
destination size limit.  This is both inefficient and can lead to linear
read overflows if a source string is not NUL-terminated [1].  In an effort
to remove strlcpy() completely [2], replace strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89



Signed-off-by: default avatarAzeem Shaikh <azeemshaikh38@gmail.com>
Link: https://lore.kernel.org/r/20230530162321.984035-1-azeemshaikh38@gmail.com


Reviewed-by: default avatarKees Cook <keescook@chromium.org>
Acked-by: default avatarDon Brace <don.brace@microchip.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent af0ce902

drivers/scsi/smartpqi/smartpqi_init.c

+1 −1
Original line number Diff line number Diff line
@@ -6841,7 +6841,7 @@ static ssize_t pqi_lockup_action_store(struct device *dev, 
	char *action_name;

	char action_name_buffer[32];



	strlcpy(action_name_buffer, buffer, sizeof(action_name_buffer));

	strscpy(action_name_buffer, buffer, sizeof(action_name_buffer));

	action_name = strstrip(action_name_buffer);



	for (i = 0; i < ARRAY_SIZE(pqi_lockup_actions); i++) {