Commit 423875c9 authored by Tobin C. Harding's avatar Tobin C. Harding Committed by Greg Kroah-Hartman
Browse files

staging: fbtft: Add check on strlcpy() return value 



Return value of strlcpy() is not checked. Name string is silently
truncated if longer that SPI_NAME_SIZE, whilst not detrimental to
the program logic it would be nice to notify the user. Module is
currently quite verbose, adding extra pr_warn() calls will not overly
impact this verbosity.

Check return value from call to strlcpy(). If source string is
truncated call pr_warn() to notify user.

Signed-off-by: default avatarTobin C. Harding <me@tobin.cc>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent dbc36405

drivers/staging/fbtft/fbtft_device.c

+7 −1
Original line number Diff line number Diff line
@@ -1483,7 +1483,13 @@ static int __init fbtft_device_init(void) 
			displays[i].pdev->name = name;

			displays[i].spi = NULL;

		} else {

			strlcpy(displays[i].spi->modalias, name, SPI_NAME_SIZE);

			size_t len;



			len = strlcpy(displays[i].spi->modalias, name,

				SPI_NAME_SIZE);

			if (len >= SPI_NAME_SIZE)

				pr_warn("modalias (name) truncated to: %s\n",

					displays[i].spi->modalias);

			displays[i].pdev = NULL;

		}

	}