Commit 426e5805 authored by Zheng Bin's avatar Zheng Bin Committed by Michael Ellerman
Browse files

powerpc/pseries/vas: Call misc_deregister if sysfs init fails 



Undo effects of misc_register if sysfs init fails after
misc_register.

Signed-off-by: default avatarZheng Bin <zhengbin13@huawei.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220511033507.2745992-1-zhengbin13@huawei.com
parent 0e0946e2

arch/powerpc/platforms/pseries/vas-sysfs.c

+2 −0
Original line number Diff line number Diff line
@@ -248,6 +248,7 @@ int __init sysfs_pseries_vas_init(struct vas_all_caps *vas_caps) 
	pseries_vas_kobj = kobject_create_and_add("vas0",

					&vas_miscdev.this_device->kobj);

	if (!pseries_vas_kobj) {

		misc_deregister(&vas_miscdev);

		pr_err("Failed to create VAS sysfs entry\n");

		return -ENOMEM;

	}
@@ -259,6 +260,7 @@ int __init sysfs_pseries_vas_init(struct vas_all_caps *vas_caps) 
		if (!gzip_caps_kobj) {

			pr_err("Failed to create VAS GZIP capability entry\n");

			kobject_put(pseries_vas_kobj);

			misc_deregister(&vas_miscdev);

			return -ENOMEM;

		}

	}