Commit 428b7f59 authored by Julian Wiedmann's avatar Julian Wiedmann Committed by Vasily Gorbik
Browse files

s390/ccwgroup: simplify ungrouping when driver deregisters 



driver_unregister() ends up calling __device_release_driver() for
each device that is bound to the driver. Thus ccwgroup_notifier() will
see a BUS_NOTIFY_UNBIND_DRIVER event for these ccwgroup devices, and
trigger the ungrouping.

So there's no need to also trigger the ungrouping from within
ccwgroup_driver_unregister(), remove it.

Signed-off-by: default avatarJulian Wiedmann <jwi@linux.ibm.com>
Reviewed-by: default avatarVineeth Vijayan <vneethv@linux.ibm.com>
Signed-off-by: default avatarVasily Gorbik <gor@linux.ibm.com>
parent 31aae32c

drivers/s390/cio/ccwgroup.c

+0 −9
Original line number Diff line number Diff line
@@ -499,15 +499,6 @@ EXPORT_SYMBOL(ccwgroup_driver_register); 
 */

void ccwgroup_driver_unregister(struct ccwgroup_driver *cdriver)

{

	struct device *dev;



	/* We don't want ccwgroup devices to live longer than their driver. */

	while ((dev = driver_find_next_device(&cdriver->driver, NULL))) {

		struct ccwgroup_device *gdev = to_ccwgroupdev(dev);



		ccwgroup_ungroup(gdev);

		put_device(dev);

	}

	driver_unregister(&cdriver->driver);

}

EXPORT_SYMBOL(ccwgroup_driver_unregister);