Commit 42b3b621 authored by Aishwarya Pant's avatar Aishwarya Pant Committed by Greg Kroah-Hartman
Browse files

staging: rtl8723bs: remove implicit int->bool conversions 



Implicit type conversions are bad; they hinder readability of code and
have potential to cause bugs. Here the variable wait_ack is always
supplied a bool value while in function declarations it is defined as an
int type. Fix it by defining wait_ack a bool type in all usages.

Signed-off-by: default avatarAishwarya Pant <aishpant@gmail.com>
Acked-by: default avatarJulia Lawall <julia.lawall@lip6.fr>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b739ea41

drivers/staging/rtl8723bs/core/rtw_mlme_ext.c

+9 −4
Original line number Diff line number Diff line
@@ -2831,7 +2831,9 @@ void issue_probersp(struct adapter *padapter, unsigned char *da, u8 is_valid_p2p 


}



static int _issue_probereq(struct adapter *padapter, struct ndis_802_11_ssid *pssid, u8 *da, u8 ch, bool append_wps, int wait_ack)

static int _issue_probereq(struct adapter *padapter,

			   struct ndis_802_11_ssid *pssid,

			   u8 *da, u8 ch, bool append_wps, bool wait_ack)

{

	int ret = _FAIL;

	struct xmit_frame		*pmgntframe;
@@ -3430,7 +3432,8 @@ void issue_assocreq(struct adapter *padapter) 
}



/* when wait_ack is ture, this function shoule be called at process context */

static int _issue_nulldata(struct adapter *padapter, unsigned char *da, unsigned int power_mode, int wait_ack)

static int _issue_nulldata(struct adapter *padapter, unsigned char *da,

			   unsigned int power_mode, bool wait_ack)

{

	int ret = _FAIL;

	struct xmit_frame			*pmgntframe;
@@ -3591,7 +3594,8 @@ s32 issue_nulldata_in_interrupt(struct adapter *padapter, u8 *da) 
}



/* when wait_ack is ture, this function shoule be called at process context */

static int _issue_qos_nulldata(struct adapter *padapter, unsigned char *da, u16 tid, int wait_ack)

static int _issue_qos_nulldata(struct adapter *padapter, unsigned char *da,

			       u16 tid, bool wait_ack)

{

	int ret = _FAIL;

	struct xmit_frame			*pmgntframe;
@@ -3715,7 +3719,8 @@ int issue_qos_nulldata(struct adapter *padapter, unsigned char *da, u16 tid, int 
	return ret;

}



static int _issue_deauth(struct adapter *padapter, unsigned char *da, unsigned short reason, u8 wait_ack)

static int _issue_deauth(struct adapter *padapter, unsigned char *da,

			 unsigned short reason, bool wait_ack)

{

	struct xmit_frame			*pmgntframe;

	struct pkt_attrib			*pattrib;