Commit 42bdb41d authored by Longji Guo's avatar Longji Guo Committed by Greg Kroah-Hartman
Browse files

staging: rtl8723bs: remove meaningless pstat->passoc_req check in OnAssocReq() 



kfree(NULL) is safe and the check 'if (pstat->passoc_req)' before kfree
is not necessary.

Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarLongji Guo <guolongji@uniontech.com>
Link: https://lore.kernel.org/r/20210929110613.29979-1-guolongji@uniontech.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6649335e

drivers/staging/rtl8723bs/core/rtw_mlme_ext.c

+2 −6
Original line number Diff line number Diff line
@@ -1344,12 +1344,8 @@ unsigned int OnAssocReq(struct adapter *padapter, union recv_frame *precv_frame) 
			issue_asocrsp(padapter, status, pstat, WIFI_REASSOCRSP);



		spin_lock_bh(&pstat->lock);

		if (pstat->passoc_req) {

		kfree(pstat->passoc_req);

			pstat->passoc_req = NULL;

		pstat->assoc_req_len = 0;

		}



		pstat->passoc_req =  rtw_zmalloc(pkt_len);

		if (pstat->passoc_req) {

			memcpy(pstat->passoc_req, pframe, pkt_len);