Commit 44346191 authored by Jessica Zhang's avatar Jessica Zhang Committed by Dmitry Baryshkov
Browse files

drm/msm/dpu: Use fixed DRM DSC helper for det_thresh_flatness 



The current dpu_hw_dsc calculation for det_thresh_flatness does not
match the downstream calculation or the DSC spec.

Use the DRM DSC helper for det_thresh_flatness to match downstream
implementation and the DSC spec.

Fixes: c110cfd1 ("drm/msm/disp/dpu1: Add support for DSC")
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: default avatarMarijn Suijten <marijn.suijten@somainline.org>
Signed-off-by: default avatarJessica Zhang <quic_jesszhan@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/539275/
Link: https://lore.kernel.org/r/20230329-rfc-msm-dsc-helper-v14-6-bafc7be95691@quicinc.com


Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
parent b50f06f8

drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c

+3 −1
Original line number Diff line number Diff line
@@ -3,6 +3,8 @@ 
 * Copyright (c) 2020-2022, Linaro Limited

 */



#include <drm/display/drm_dsc_helper.h>



#include "dpu_kms.h"

#include "dpu_hw_catalog.h"

#include "dpu_hwio.h"
@@ -102,7 +104,7 @@ static void dpu_hw_dsc_config(struct dpu_hw_dsc *hw_dsc, 
	data |= dsc->final_offset;

	DPU_REG_WRITE(c, DSC_DSC_OFFSET, data);



	det_thresh_flatness = 7 + 2 * (dsc->bits_per_component - 8);

	det_thresh_flatness = drm_dsc_flatness_det_thresh(dsc);

	data = det_thresh_flatness << 10;

	data |= dsc->flatness_max_qp << 5;

	data |= dsc->flatness_min_qp;