Commit 44930991 authored by Guoqing Jiang's avatar Guoqing Jiang Committed by Jason Gunthorpe
Browse files

RDMA/rtrs-clt: Remove redundant code from rtrs_clt_read_req 

There is no need to dereference 's' from 'sess', since we have "sess =
to_clt_sess(s)" before.

And we can deference 'dev' from 's' earlier.

Link: https://lore.kernel.org/r/20210325153308.1214057-8-gi-oh.kim@ionos.com


Signed-off-by: default avatarGuoqing Jiang <guoqing.jiang@ionos.com>
Reviewed-by: default avatarDanil Kipnis <danil.kipnis@ionos.com>
Signed-off-by: default avatarGioh Kim <gi-oh.kim@ionos.com>
Signed-off-by: default avatarJack Wang <jinpu.wang@ionos.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 0adb3ad6

drivers/infiniband/ulp/rtrs/rtrs-clt.c

+1 −4
Original line number Diff line number Diff line
@@ -1052,7 +1052,7 @@ static int rtrs_clt_read_req(struct rtrs_clt_io_req *req) 
	struct rtrs_sess *s = con->c.sess;

	struct rtrs_clt_sess *sess = to_clt_sess(s);

	struct rtrs_msg_rdma_read *msg;

	struct rtrs_ib_dev *dev;

	struct rtrs_ib_dev *dev = sess->s.dev;



	struct ib_reg_wr rwr;

	struct ib_send_wr *wr = NULL;
@@ -1062,9 +1062,6 @@ static int rtrs_clt_read_req(struct rtrs_clt_io_req *req) 


	const size_t tsize = sizeof(*msg) + req->data_len + req->usr_len;



	s = &sess->s;

	dev = sess->s.dev;



	if (unlikely(tsize > sess->chunk_size)) {

		rtrs_wrn(s,

			  "Read request failed, message size is %zu, bigger than CHUNK_SIZE %d\n",