Commit 4516fede authored by Bjorn Helgaas's avatar Bjorn Helgaas Committed by Oded Gabbay
Browse files

accel/habanalabs: Drop redundant pci_enable_pcie_error_reporting() 



pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages. Since
commit f26e58bf ("PCI/AER: Enable error reporting when AER is native"),
the PCI core does this for all devices during enumeration, so the
driver doesn't need to do it itself.

Remove the redundant pci_enable_pcie_error_reporting() call from the
driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
from the driver .remove() path.

Note that this only controls ERR_* Messages from the device.  An ERR_*
Message may cause the Root Port to generate an interrupt, depending on the
AER Root Error Command register managed by the AER service driver.

Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
parent 2e8e9a89

drivers/accel/habanalabs/common/habanalabs_drv.c

+0 −5
Original line number Diff line number Diff line
@@ -12,7 +12,6 @@ 
#include "../include/hw_ip/pci/pci_general.h"



#include <linux/pci.h>

#include <linux/aer.h>

#include <linux/module.h>



#define CREATE_TRACE_POINTS
@@ -549,8 +548,6 @@ static int hl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) 


	pci_set_drvdata(pdev, hdev);



	pci_enable_pcie_error_reporting(pdev);



	rc = hl_device_init(hdev);

	if (rc) {

		dev_err(&pdev->dev, "Fatal error during habanalabs device init\n");
@@ -561,7 +558,6 @@ static int hl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) 
	return 0;



disable_device:

	pci_disable_pcie_error_reporting(pdev);

	pci_set_drvdata(pdev, NULL);

	destroy_hdev(hdev);
@@ -584,7 +580,6 @@ static void hl_pci_remove(struct pci_dev *pdev) 
		return;



	hl_device_fini(hdev);

	pci_disable_pcie_error_reporting(pdev);

	pci_set_drvdata(pdev, NULL);

	destroy_hdev(hdev);

}