Commit 45fed3e7 authored by Paul E. McKenney's avatar Paul E. McKenney
Browse files

rcu: Make rcu_gp_init() be bool rather than int 



The return value from rcu_gp_init() is always used as a bool, so
this commit makes it be a bool.

Reported-by: default avatarIftekhar Ahmed <ahmedi@oregonstate.edu>
Signed-off-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
parent e11f1335

kernel/rcu/tree.c

+5 −5
Original line number Original line Diff line number Diff line
@@ -1814,9 +1814,9 @@ static void rcu_gp_slow(struct rcu_state *rsp, int delay) 
}

}





/*

/*

 * Initialize a new grace period.  Return 0 if no grace period required.

 * Initialize a new grace period.  Return false if no grace period required.

 */

 */

static int rcu_gp_init(struct rcu_state *rsp)

static bool rcu_gp_init(struct rcu_state *rsp)

{

{

	unsigned long oldmask;

	unsigned long oldmask;

	struct rcu_data *rdp;

	struct rcu_data *rdp;
@@ -1827,7 +1827,7 @@ static int rcu_gp_init(struct rcu_state *rsp) 
	if (!READ_ONCE(rsp->gp_flags)) {

	if (!READ_ONCE(rsp->gp_flags)) {

		/* Spurious wakeup, tell caller to go back to sleep.  */

		/* Spurious wakeup, tell caller to go back to sleep.  */

		raw_spin_unlock_irq(&rnp->lock);

		raw_spin_unlock_irq(&rnp->lock);

		return 0;

		return false;

	}

	}

	WRITE_ONCE(rsp->gp_flags, 0); /* Clear all flags: New grace period. */

	WRITE_ONCE(rsp->gp_flags, 0); /* Clear all flags: New grace period. */
@@ -1837,7 +1837,7 @@ static int rcu_gp_init(struct rcu_state *rsp) 
		 * Not supposed to be able to happen.

		 * Not supposed to be able to happen.

		 */

		 */

		raw_spin_unlock_irq(&rnp->lock);

		raw_spin_unlock_irq(&rnp->lock);

		return 0;

		return false;

	}

	}





	/* Advance to a new grace period and initialize state. */

	/* Advance to a new grace period and initialize state. */
@@ -1929,7 +1929,7 @@ static int rcu_gp_init(struct rcu_state *rsp) 
		WRITE_ONCE(rsp->gp_activity, jiffies);

		WRITE_ONCE(rsp->gp_activity, jiffies);

	}

	}





	return 1;

	return true;

}

}





/*

/*